Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prewarmer to existing tests #7272

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

smartprogrammer93
Copy link
Contributor

Changes

  • add prewarmer tests to existing blockchain tests

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

@@ -377,7 +377,8 @@ protected virtual async Task AddBlocksOnStart()
State,
ReceiptStorage,
new BlockhashStore(SpecProvider, State),
LogManager);
LogManager,
preWarmer: new BlockCachePreWarmer(new ReadOnlyTxProcessingEnvFactory(WorldStateManager, BlockTree, SpecProvider, LogManager, WorldStateManager.GlobalWorldState), SpecProvider, LogManager, WorldStateManager.GlobalWorldState));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add method to create pre-warmer in TestBlockchain class, so we don't have to duplicate this code and just call that method?

@smartprogrammer93 smartprogrammer93 force-pushed the fix/add-prewarmer-to-existing-tests branch from 2375cb3 to f379c46 Compare August 23, 2024 17:21
@smartprogrammer93 smartprogrammer93 marked this pull request as ready for review August 23, 2024 17:22
@smartprogrammer93 smartprogrammer93 merged commit 21b833f into master Aug 23, 2024
66 checks passed
@smartprogrammer93 smartprogrammer93 deleted the fix/add-prewarmer-to-existing-tests branch August 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants